Merged
Conversation
davidhewitt
reviewed
Jan 27, 2024
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Thank you very much for help with these implementations!
I think regarding __complex__, switching the return type to Bound hopefully already works with the traits we've got.
63 tasks
davidhewitt
approved these changes
Jan 27, 2024
Member
davidhewitt
left a comment
davidhewitt
left a comment
There was a problem hiding this comment.
Great, this looks good to me, thanks very much again for the help here 👍
If you're interested in doing more and want ideas what to look into next, please do feel welcome to ping me on #3684!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports
PyComplexto the new Bound API from #3684.Binary operator are implemented for different combinations of
Bound,&Bound, as well as forBorrowedand GIL-refs. The inherentpowmethod is left with GIL-refs for backwards compatibility (I think its only callable from GIL-refs anyways?), the one on the trait uses the new API.I think the magic
__complex__method can be changed together with other magic methods that currently return GIL-refs.