implement PyBytesMethods and PyByteArrayMethods#3651
Merged
davidhewitt merged 2 commits intoPyO3:mainfrom Dec 19, 2023
Merged
Conversation
Closed
davidhewitt
commented
Dec 14, 2023
adamreichold
approved these changes
Dec 15, 2023
Member
adamreichold
left a comment
adamreichold
left a comment
There was a problem hiding this comment.
LGTM except for the stray TODO comment
Member
Author
|
Thanks again for all the reviews this week, I'm really excited to have some momentum on the new API! |
Member
|
@davidhewitt Won't this fail due to the Clippy warning for the self convention on |
Member
Author
|
Oh yikes, probably, yes. I've cancelled the merge and will fixup. Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
PyBytesMethodsandPyByteArrayMethodstraits as per #3382The main interesting thing here is that to be able to forward the
.as_bytes()and.as_bytes_mut()methods from the gil refs to the underlying types, I had to extend the lifetime of the returned slices. Unclear to me if there's a way to change things to not need this.