ci: pool can be dirty from other threads #3225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
approved these changes
Jun 11, 2023
Member
adamreichold
left a comment
adamreichold
left a comment
There was a problem hiding this comment.
Agreed. I have also hit this a few times, but just never found the motivation to try to actually fix it. Thanks!
davidhewitt
force-pushed
the
pool-can-be-dirty
branch
from
8401538 to
7fd5945
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
ritchie46
pushed a commit
to pola-rs/pyo3
that referenced
this pull request
Dec 5, 2024
ci: pool can be dirty from other threads
ritchie46
pushed a commit
to pola-rs/pyo3
that referenced
this pull request
Dec 5, 2024
ci: pool can be dirty from other threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit this failure in CI: https://github.com/PyO3/pyo3/actions/runs/5237094306/jobs/9455062113?pr=2709#step:19:732
I'm pretty sure what's going on there is that
pool_not_dirty()is too strong an assertion - another thread which is testing putting a delayed clone or drop onto the pool can trigger a race. I was able to reproduce the same race before applying this patch.