Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the deck dimensions for Hamilton STAR and STARlet systems to reflect their actual working deck sizes, excluding the rightmost waste block area. The changes ensure that deck size calculations are consistent with the usable rail space for labware placement.
Changes:
- Reduced
STARLET_SIZE_Xfrom 1360mm to 1005mm andSTAR_SIZE_Xfrom 1900mm to 1545mm to reflect actual deck dimensions - Refactored trash positioning to be relative to the waste block location instead of using a hardcoded offset from the right edge
- Added
with_waste_blockparameter to control waste block creation independently of teaching rack
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pylabrobot/resources/hamilton/hamilton_decks.py | Updated STAR/STARlet deck size constants, refactored trash/waste block initialization order, and excluded Trash from collision detection |
| pylabrobot/resources/deck.py | Updated default deck size_x to match new STARlet dimensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rickwierenga
reviewed
Feb 6, 2026
rickwierenga
reviewed
Feb 6, 2026
rickwierenga
reviewed
Feb 6, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit bece8b7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.