Skip to content

document cmm #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 12, 2024
Merged

document cmm #290

merged 6 commits into from
Nov 12, 2024

Conversation

rickwierenga
Copy link
Member

#69

@rickwierenga rickwierenga requested a review from BioCam October 26, 2024 01:33
@BioCam
Copy link
Contributor

BioCam commented Oct 26, 2024

Shall we get the new and upgraded probing functions from PR260 into PR and then get on the documentation with the updated versions?

@rickwierenga
Copy link
Member Author

the z-probing from 260 can be a new section in this notebook. I hope to merge 260 next week now that my robot is free of <>, at which point we could update this notebook. should we block this on that pr, or merge now and update later?

@rickwierenga
Copy link
Member Author

todo reminder: put Camillo's video in the doc

@rickwierenga
Copy link
Member Author

rickwierenga commented Nov 11, 2024

@BioCam i updated with #260 and your video. what do you think?

rendered: https://github.com/PyLabRobot/pylabrobot/blob/8e2ae94a813ced69aabe5a7a659af170440cfd51/docs/user_guide/hamilton-star/z-probing.ipynb

@BioCam
Copy link
Contributor

BioCam commented Nov 12, 2024

This looks fantastic!

I think...

  • the last link to mapping a 3D surface is not working?
  • we can hyperlink the clld_probing video to the clld_probing section for visualisation purposes. Is it possible to embed the YouTube video directly?
    (haven't tried it yet)

@rickwierenga
Copy link
Member Author

the last link to mapping a 3D surface is not working?

That should be fixed when rendered into html. MyST-NB uses a slightly different format than normal/github jupyter notebooks for hyperlinks.

we can hyperlink the clld_probing video to the clld_probing section for visualisation purposes. Is it possible to embed the YouTube video directly?

Yes, already embedded! Just not rendered by GitHub, but will be rendered if you make docs locally :)

https://github.com/PyLabRobot/pylabrobot/pull/290/files#diff-20abf20190ef22190a8bb002eedd1bd832ccc1e71ca05586403c2f39a7932adfR232

image

@rickwierenga rickwierenga merged commit 09af6c7 into main Nov 12, 2024
7 checks passed
@rickwierenga rickwierenga deleted the cmm-doc branch November 12, 2024 21:26
rickwierenga added a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants