Skip to content

Fix crashing the SPD3303X processor when saving #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix crashing the SPD3303X processor when saving #228

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57d765c
Added a slow write function. `save.*` now uses the slow write function.
Sep 5, 2025
c2e25c2
Changed aproach to use a lambda and kwarg delay to add an extra 30 ms…
Sep 11, 2025
3969589
Updated timing for `save.*` to be 100 ms because the SPD3303X is junk
Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/fixate/drivers/pps/siglent_spd_3303X.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ def __init__(self, instrument):

self.api = [
# Save commands
("save.group1", self.write, "*SAV 1"),
("save.group2", self.write, "*SAV 2"),
("save.group3", self.write, "*SAV 3"),
("save.group4", self.write, "*SAV 4"),
("save.group5", self.write, "*SAV 5"),
("save.group1", lambda cmd: self._write(cmd, delay=0.1), "*SAV 1"),
("save.group2", lambda cmd: self._write(cmd, delay=0.1), "*SAV 2"),
("save.group3", lambda cmd: self._write(cmd, delay=0.1), "*SAV 3"),
("save.group4", lambda cmd: self._write(cmd, delay=0.1), "*SAV 4"),
("save.group5", lambda cmd: self._write(cmd, delay=0.1), "*SAV 5"),
# Recall commands
("recall.group1", self.write, "*RCL 1"),
("recall.group2", self.write, "*RCL 2"),
Expand Down Expand Up @@ -189,7 +189,7 @@ def _read_value(self, data):
self._is_error()
return values[0]

def _write(self, data):
def _write(self, data, delay=0.0):
"""
The SPD3303X cannot respond to visa commands as quickly as some other devices
A 20ms delay was found to be reliable for most commands.
Expand All @@ -202,7 +202,7 @@ def _write(self, data):
"""
for cmd in data.split(";"):
self.instrument.write(cmd)
time.sleep(0.02 + len(cmd) / 6000)
time.sleep(0.02 + delay + len(cmd) / 6000)
self._is_error()

@staticmethod
Expand Down
Loading