DMM Drivers - NPLC and Min/Max/Avg support #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jasper-Harvey0
requested changes
Nov 25, 2024
…tor. updated keithley unused variable to be an underscore to be more correct
add get_nplc function to query the nplc from the dmm this applies to both the fluke and keithley dmm drivers
made min_avg_max return dictionary instead of the individual values
add funcgen to min_avg_max test to verify that it's working update keithley driver to manually default to an NPLC of 1 as the "DEF" keyword is incorrect
Jasper-Harvey0
requested changes
Dec 3, 2024
Collaborator
Jasper-Harvey0
left a comment
Jasper-Harvey0
left a comment
There was a problem hiding this comment.
Not done yet. I will come back in a little bit
Jasper-Harvey0
requested changes
Dec 5, 2024
Collaborator
Jasper-Harvey0
left a comment
Jasper-Harvey0
left a comment
There was a problem hiding this comment.
I think I am happy with this after you do the changes.
Please update the release notes. You will have to pull in the recent changes from main I think?
@clint-lawrence @jcollins1983 Are you two happy to proceed?
Collaborator
Yep, my earlier comment have all been address. |
…compatibility between DMMs)
Jasper-Harvey0
approved these changes
Dec 8, 2024
Collaborator
Jasper-Harvey0
left a comment
Jasper-Harvey0
left a comment
There was a problem hiding this comment.
Looks good to me
Jasper-Harvey0
requested changes
Dec 8, 2024
Collaborator
Jasper-Harvey0
left a comment
Jasper-Harvey0
left a comment
There was a problem hiding this comment.
Update release notes please!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to configure NPLC on a driver level in both the Fluke and Keithley DMM drivers
Added a function to have the drivers sample x times and then return the minimum, maximum and average of the samples