produce an error when a definition shadows an unused assignment (#761)

PyCQA · Jan 12, 2023 · e932464 · e932464
1 parent 33bbb82
commit e932464
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/pyflakes/checker.py b/pyflakes/checker.py
@@ -263,6 +263,11 @@ class Definition(Binding):
     """
     A binding that defines a function or a class.
     """
+    def redefines(self, other):
+        return (
+            super().redefines(other) or
+            (isinstance(other, Assignment) and self.name == other.name)
+        )
 
 
 class Builtin(Definition):

diff --git a/pyflakes/test/test_other.py b/pyflakes/test/test_other.py
@@ -118,6 +118,12 @@ def a(): pass
         def a(): pass
         ''', m.RedefinedWhileUnused)
 
+    def test_redefined_function_shadows_variable(self):
+        self.flakes('''
+        x = 1
+        def x(): pass
+        ''', m.RedefinedWhileUnused)
+
     def test_redefinedUnderscoreFunction(self):
         """
         Test that shadowing a function definition named with underscore doesn't