We actually now have code that attempts to traverse as much of the class hierarchy as is possible (given the AST's limitations). We use it to find Exception subclasses.

pep8-naming/src/pep8ext_naming.py

Lines 300 to 316 in 9adbbc4

    
           def get_classdef(cls, name, parents): 
        
               for parent in parents: 
        
                   for node in parent.body: 
        
                       if isinstance(node, ast.ClassDef) and node.name == name: 
        
                           return node 
        
           @classmethod 
        
           def superclass_names(cls, name, parents, _names=None): 
        
               names = _names or set() 
        
               classdef = cls.get_classdef(name, parents) 
        
               if not classdef: 
        
                   return names 
        
               for base in classdef.bases: 
        
                   if isinstance(base, ast.Name) and base.id not in names: 
        
                       names.add(base.id) 
        
                       names.update(cls.superclass_names(base.id, parents, names)) 
        
               return names

A path to implementing the suggestion in this issue might be:

Generalize the code above
Introduce an ignore-class-names (or similar) configuration option which skips all (or a subset of?) checks for matching subclasses
Consider defaulting the list of ignored class names to ["TypedDict"]

TypedDict classes should be exempt from N815 #178

Description

gaborbernatopenedon Sep 15, 2021

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

gaborbernat
openedon Sep 15, 2021