Recommend six 1.9.0, and have Travis-CI test using that version. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
|
(Travis was probably already using 1.9.0 in any case because it is a >= constraint, which is why the tests didn't fail when the fix for #99 was committed. But a more precise constraint can't hurt) |
|
I don't think that part of the test actually relies on six at all - it just compares the output code to what it expects, it doesn't actually try running it. Either way, I think this is fine. |
brettcannon
added a commit
that referenced
this pull request
Jan 9, 2015
…ix-version Recommend six 1.9.0, and have Travis-CI test using that version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daira Hopwood daira@jacaranda.org