Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2.6 #507

Merged
merged 1 commit into from
Jun 1, 2017
Merged

Drop support for Python 2.6 #507

merged 1 commit into from
Jun 1, 2017

Conversation

jdufresne
Copy link
Collaborator

I would humbly like to suggest isort drops support for Python 2.6.

The last release of Python 2.6 was 2013-10-29, over 3 years ago. It is
no longer receiving security fixes.

https://www.python.org/dev/peps/pep-0361/

The pip project itself has recently dropped support for 2.6. Their
numbers estimate that Python 2.6 accounts for ~2% of their downloads.
See:

pypa/pip#4343

For projects that still use Python 2.6, they can continue to pip install
an older version of isort.

I've tried my best to remove as much 2.6 specific code as I can,
including the 'Programming Language :: Python :: 2.6' trove classifier
from setup.py. I've also removed Travis CI testing, which should result
in faster testing and fewer wasted resources.

Code changed:

  • Removed Python2.6 from documentation
  • Removed Python2.6 from testing configuration
  • Use set literals
  • Use dict comprehension
  • Pass generator expressions to builtin functions instead of lists
  • Use builtin OrderedDict
  • Removed deprecated U open mode; replace with io.open() which support
    universal newlines
  • Removed Python2.6 workarounds throughout the code

Thanks for considering.

@timothycrosley
Copy link
Member

I agree with this sentiment. I'll try to push one more version of isort with 2.6 support using the many fixes that are waiting in develop and that afterwards merge this in and go with 2.7+ going forward. Honestly, I look forward to the day I only have to support 3, like the case is for hug.

Thanks for all the great work!

~Timothy

@jdufresne
Copy link
Collaborator Author

Honestly, I look forward to the day I only have to support 3

If you'd like, I can modify this PR or submit a follow up PR to drop all Python 2 support. What is your preference? I was trying to be conservative by continuing support for Python 2.7. I'm only involved with Python 3 projects, so my projects would continue using the latest isort version. Let me know what you think.

@timothycrosley
Copy link
Member

timothycrosley commented May 8, 2017

I think your initial intuition was correct, as there unfortunately still many 2.7 projects. I'll push out one final 2.6 release this week, merge in this change and support 2.7 - through the rest of the year and then 3+ only.

Thanks!

~Timothy

@jdufresne
Copy link
Collaborator Author

Rebased to resolve merge conflicts

I would humbly like to suggest isort drops support for Python 2.6.

The last release of Python 2.6 was 2013-10-29, over 3 years ago. It is
no longer receiving security fixes.

https://www.python.org/dev/peps/pep-0361/

The pip project itself has recently dropped support for 2.6. Their
numbers estimate that Python 2.6 accounts for ~2% of their downloads.
See:

pypa/pip#4343

For projects that still use Python 2.6, they can continue to pip install
an older version of isort.

I've tried my best to remove as much 2.6 specific code as I can,
including the 'Programming Language :: Python :: 2.6' trove classifier
from setup.py. I've also removed Travis CI testing, which should result
in faster testing and fewer wasted resources.

Code changed:

- Removed Python2.6 from documentation
- Removed Python2.6 from testing configuration
- Use set literals
- Use dict comprehension
- Pass generator expressions to builtin functions instead of lists
- Use builtin OrderedDict
- Removed deprecated U open mode; replace with io.open() which support
  universal newlines
- Removed Python2.6 workarounds throughout the code

Thanks for considering.
@timothycrosley
Copy link
Member

The last Python2.6 release has just been pushed! 4.2.8. Thanks for the great work!

@timothycrosley timothycrosley merged commit 363b67a into PyCQA:develop Jun 1, 2017
@jdufresne jdufresne deleted the py26 branch June 1, 2017 13:31
timothycrosley added a commit that referenced this pull request Jun 1, 2017
This reverts commit 363b67a, reversing
changes made to df3a4a0.
@jdufresne
Copy link
Collaborator Author

Any reason this was reverted?

@timothycrosley
Copy link
Member

Definitely unintentionally. I accidentally merged it into master from a hot fix branch and then had to revert it to do further hotifixes (this is what happens when you don't do a release in over a year O:-) and I'm sure I at some point merged master back in to make develop in sync with the latest.

@jdufresne
Copy link
Collaborator Author

No worries. I've restored the change in PR #562.

timothycrosley added a commit that referenced this pull request Jun 4, 2017
Revert "Revert "Merge pull request #507 from jdufresne/py26""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants