-
-
Notifications
You must be signed in to change notification settings - Fork 611
chore: replace black with ruff in clean.sh #2448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace black with ruff in clean.sh #2448
Conversation
23c232e to
658c7af
Compare
658c7af to
9a63780
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2448 +/- ##
==========================================
- Coverage 99.25% 99.25% -0.01%
==========================================
Files 40 40
Lines 3094 3089 -5
Branches 681 680 -1
==========================================
- Hits 3071 3066 -5
Misses 13 13
Partials 10 10 🚀 New features to boost your workflow:
|
DanielNoord
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is kind of strange to me that the Lint job doesn't fail without this change. Is it possible that we also need to update that job so we also check everything in scripts for formatting?
|
Hey @DanielNoord, from my understanding the CI did not fail because the imports in scripts were already sorted and formatting was already covered by |
f58e470 to
8a97221
Compare
DanielNoord
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a small commit :)
8a97221 to
5cff82a
Compare
Description
After running the
./scripts/done.shit reveled a lot of code formatting that should be fixed (+1321, -486). Then analyzing the workflow i noticed that we are actually using ruff. So instead of add the lint changes and i'm just going to update the clean script to use ruffRelated issue