Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stage names for pre-commit #2296

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthewhughes934
Copy link
Contributor

pre-commit v4.0.0 added a warning to deprecated stage names[1] so update these names to avoid the warning. This also required updating the minimum pre-commit version to one that supports the new names

See also[2] for a similar change and the docs[3].

[1] https://github.com/pre-commit/pre-commit/blob/cc4a52241565440ce200666799eef70626457488/CHANGELOG.md#400---2024-10-05
[2] pre-commit/pre-commit-hooks@003dfa5
[3] https://pre-commit.com/#confining-hooks-to-run-at-certain-stages

Fixes: #2294

`pre-commit` v4.0.0 added a warning to deprecated stage names[1] so
update these names to avoid the warning. This also required updating the
minimum `pre-commit` version to one that supports the new names

See also[2] for a similar change and the docs[3].

[1] https://github.com/pre-commit/pre-commit/blob/cc4a52241565440ce200666799eef70626457488/CHANGELOG.md#400---2024-10-05
[2] pre-commit/pre-commit-hooks@003dfa5
[3] https://pre-commit.com/#confining-hooks-to-run-at-certain-stages

Fixes: PyCQA#2294
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.15%. Comparing base (7de1829) to head (4eeb37a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2296   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          39       39           
  Lines        3091     3091           
  Branches      748      748           
=======================================
  Hits         3065     3065           
  Misses         15       15           
  Partials       11       11           

@eirnym eirnym mentioned this pull request Nov 26, 2024
@eirnym
Copy link

eirnym commented Nov 26, 2024

Could you please rebase/merge main to check if this would fix security checks

@matthewhughes934
Copy link
Contributor Author

matthewhughes934 commented Nov 26, 2024

Could you please rebase/merge main to check if this would fix security checks

The branch looks to be up to date with main: commit 4eeb37a is on top of the current tip of main (though the last commit on main was ~10 months ago)

$ git log --max-count=2 --format='%H %s'
4eeb37a8cda544171d223c00b4729eaefd1528b6 Update stage names for `pre-commit`
7de182933fd50e04a7c47cc8be75a6547754b19c Merge pull request #2223 from PyCQA/dependabot/pip/gitpython-3.1.41

@eirnym
Copy link

eirnym commented Nov 26, 2024

It's sad to see security check failing because of vulnerable main branch. I had a little bit of hope that this would fix failing job.

@matthewhughes934 matthewhughes934 deleted the update-pre-commit-stages branch December 8, 2024 10:42
@matthewhughes934 matthewhughes934 restored the update-pre-commit-stages branch December 25, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning deprecated stage with pre-commit v4
3 participants