Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fix for normalizing imports from more than one level of parent modules (issue/2152) #2191

Merged
merged 2 commits into from
Dec 10, 2023

Conversation

bp72
Copy link
Contributor

@bp72 bp72 commented Oct 21, 2023

Closes #2152

@@ -5,7 +5,7 @@
from pathlib import Path
from typing import Iterator, NamedTuple, Optional, TextIO, Tuple

from isort.parse import _normalize_line, _strip_syntax, skip_line
from isort.parse import _strip_syntax, normalize_line, skip_line
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the same logic, I would rename _strip_syntax to strip_syntax. It will be better if you could also do it ;)

Copy link
Collaborator

@staticdev staticdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @bp72 do you mind checking the suggestion I made?

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #2191 (a8fc20c) into main (9f7e0e5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2191   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          39       39           
  Lines        3089     3090    +1     
  Branches      748      748           
=======================================
+ Hits         3063     3064    +1     
  Misses         15       15           
  Partials       11       11           

@bp72
Copy link
Contributor Author

bp72 commented Dec 9, 2023

@staticdev sorry, missed the comment :) It's renamed now.

@bp72 bp72 requested a review from staticdev December 9, 2023 14:48
@staticdev staticdev merged commit 4be9850 into PyCQA:main Dec 10, 2023
20 of 21 checks passed
@staticdev
Copy link
Collaborator

Thanks @bp72, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unrecoverable exception with from ..import ccc
2 participants