-
-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a fix for normalizing imports from more than one level of parent modules (issue/2152) #2191
Conversation
isort/identify.py
Outdated
@@ -5,7 +5,7 @@ | |||
from pathlib import Path | |||
from typing import Iterator, NamedTuple, Optional, TextIO, Tuple | |||
|
|||
from isort.parse import _normalize_line, _strip_syntax, skip_line | |||
from isort.parse import _strip_syntax, normalize_line, skip_line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the same logic, I would rename _strip_syntax
to strip_syntax
. It will be better if you could also do it ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @bp72 do you mind checking the suggestion I made?
…t modules (issue/2152)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2191 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 39 39
Lines 3089 3090 +1
Branches 748 748
=======================================
+ Hits 3063 3064 +1
Misses 15 15
Partials 11 11 |
@staticdev sorry, missed the comment :) It's renamed now. |
Thanks @bp72, LGTM. |
Closes #2152