Isort orders module-level dunders #2060
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2060 +/- ##
==========================================
+ Coverage 98.80% 98.81% +0.01%
==========================================
Files 38 38
Lines 3085 3118 +33
Branches 745 755 +10
==========================================
+ Hits 3048 3081 +33
Misses 26 26
Partials 11 11 |
staticdev
requested changes
Jan 15, 2023
There was a problem hiding this comment.
@clavedeluna thanks for the contribution! Could you please check the linting errors?
clavedeluna
force-pushed
the
1980-dunder-imports
branch
2 times, most recently
from
ea33a3e to
359e2e3
Compare
clavedeluna
force-pushed
the
1980-dunder-imports
branch
from
359e2e3 to
f79ac06
Compare
|
This PR is currently blocked until this question #1980 (comment) is answered / resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1980
This PR adds functionality for isort to order any module-level dunders including multi-line dunder assignments.