Disregard skip options for streamed files #2002
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip_gitignore
is kinda slow, but it's much faster than having to process all files in the repo. At least when I'm processing multiple files at once.During daily development, I use the vscode "Sort Imports" feature, which internally streams the contents of the file to
isort
. In this case, it is unbearably slow:That's 37 times slower.
If we're streaming in data, it probably makes sense to just disregard all skip conditions.