Add indent-size option - [closed]

[asottile]

In GitLab by @Toogy on Jan 18, 2017, 04:50

Merges multi-indent -> master

flake8 relying on pycodestyle for checking the coding style, the ability to have a custom indent size (number of spaces used for indentation) needs to be added there.

There's already a PR hanging on GitHub for that: PyCQA/pycodestyle#524. It was not up-to-date so I took care of rebasing on the initial pycodestyle repository's master branch and submitted a PR to the initial forker: ArgentFalcon/pycodestyle#1.

This PR here adds an indent-size option to flake8 that uses the option added to pycodestyle by the initial PR.

It's getting a little bit complicated with all those forks and PRs but basically it works! All tests passing on both repositories (the initial PR added a test to verify that the indent-size setting was working correctly) and I empirically tested the new feature on my code base with various indent-size values.

Of course, builds won't be passing before the pycodestyle PR is merged.

[asottile]

In GitLab by @asottile on Jan 16, 2020, 11:00

this patch looks fine, but needs a rebase -- we also can't merge it until pycodestyle merges theirs (well, we could, but I can already imagine the "--indent-size doesn't work!!1" issues we'll get if it does nothing)

[asottile]

In GitLab by @Toogy on May 13, 2020, 09:00

@asottile hey this is super old, not sure if i should work on it. could you let me know?

[asottile]

In GitLab by @Toogy on May 13, 2020, 09:01

apparently yes. i'll do a rebase

[asottile]

In GitLab by @workitharder on Nov 20, 2020, 21:44

I've gotten the necessary change into pycodestyle (nee flake8).
PyCQA/pycodestyle#970

So this should be unblocked, now.

[asottile]

In GitLab by @asottile on Mar 14, 2021, 12:03

via !467

[asottile]

In GitLab by @asottile on Mar 14, 2021, 12:03

changed the description