Ban more imports from typing_extensions as part of Y023
#459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
(We should wait for python/typeshed#11244 to be merged, so we can get a proper report from typeshed_primer) |
srittau
approved these changes
Jan 5, 2024
This comment has been minimized.
This comment has been minimized.
|
⚠ Flake8 diff showing the effect of this PR on typeshed: > ./stdlib/builtins.pyi:59:1: Y023 Use "typing.Literal" instead of "typing_extensions.Literal" |
| "SupportsRound", | ||
| "TypedDict", | ||
| "TypeVar", | ||
| "final", | ||
| "overload", | ||
| "NoReturn", | ||
| # ClassVar deliberately omitted, |
There was a problem hiding this comment.
Is this comment still accurate? There are now several others in the list that can be parameterized (Generic, Literal, Protocol).
There was a problem hiding this comment.
I think ClassVar is probably the only one worth special-casing in error messages. But if you'd like to PR something up special-casing some of the others in error messages as well, feel free :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.