Skip to content

Improve CI #128

Closed
Closed
@AlexWaygood

Description

Neither of these should be a massive priority, but there are two changes that might be good:

  • Run mypy with --strict. There are still a fair few dynamically typed functions in the code base; these need type annotations to be added for us to start doing this.
  • Add a pre-commit bot to auto-reformat a PR with black and isort. I think this dramatically improved the contributor experience over at typeshed. We obviously have far fewer contributors over at flake8-pyi, so it really doesn't need to be prioritised. However, this kind of auto-reformatting also makes it much easier to prepare (or start preparing) a PR on an iPad or mobile device, which is something I like to do :)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions