Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure float infinity/NaN does not trigger B008 #155

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

erichang-bcad
Copy link
Contributor

This PR addresses issue #154, and make sure float infinity/NaN does not trigger a B008 error. Some unit tests are added.

I tested this code on Python 3.9, I don't know how to test this on Python 3.7 or below (note that this is needed because the ast
module behavior for constants changed), do you have regressions that check across versions automatically?

@cooperlees
Copy link
Collaborator

cooperlees commented Jan 28, 2021

We do have CI. I don't know why it triggered. I clicked re-run and it seems to be running now. Lets see how things go in the older versions of python. Thanks!

Edit: They all passed.

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aweosme, thanks! All LGTM with good test coverage. Will leave for a day or two for others to weigh in if they wish.

@cooperlees cooperlees merged commit c636077 into PyCQA:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants