Respect color environment variables if set #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwb
requested review from
lukehinds,
ghugo and
sigmavirus24
as code owners
13 tasks
According to command line standards [1], a command line should do its best to honor certain environment variables requesting whether color should be part of the standard output. Two such vars include NO_COLOR (if set) and TERM (if set to dumb), when set tell the CLI to disable color. [1] https://clig.dev/#output Partially-fixes #678 Signed-off-by: Eric Brown <browne@vmware.com>
|
If we switch to Rich, I think it honors this for us |
True, but Rich brings in a lot of other function I don't think we need at this time. |
|
Honestly, I think our formatting could be better done via rich. We can do that in another PR though |
sigmavirus24
approved these changes
Feb 17, 2022
This was referenced Feb 28, 2022
Merged
Merged
This was referenced Feb 28, 2022
Merged
This was referenced Mar 7, 2022
This was referenced Mar 26, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to command line standards [1], a command line should
do its best to honor certain environment variables requesting
whether color should be part of the standard output. Two such
vars include NO_COLOR (if set) and TERM (if set to dumb), when
set tell the CLI to disable color.
[1] https://clig.dev/#output
Partially-fixes #678
Signed-off-by: Eric Brown browne@vmware.com