-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of the CWEMAP dict #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwb
requested review from
ghugo,
lukehinds and
sigmavirus24
as code owners
February 2, 2022 00:14
ericwb
force-pushed
the
rm_cwemap
branch
3 times, most recently
from
February 2, 2022 00:48
aea480c
to
00e810f
Compare
There is a lookup dictionary defined that maps bandit check IDs to a CWE. This is mostly unnecessary as the check can specify the exact CWE that applies to it. And this would work better for 3rd party plugins that also wish to set a CWE for their check. Maintaining a map is just another bit of maintenance. Signed-off-by: Eric Brown <browne@vmware.com>
sigmavirus24
approved these changes
Feb 2, 2022
This was referenced Feb 28, 2022
Merged
Merged
This was referenced Feb 28, 2022
chore(deps): update pre-commit hook pycqa/bandit to v1.7.3
browniebroke/flake8-django-migrations#174
Merged
Merged
This was referenced Mar 7, 2022
This was referenced Mar 26, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a lookup dictionary defined that maps bandit check IDs
to a CWE. This is mostly unnecessary as the check can specify
the exact CWE that applies to it. And this would work better for
3rd party plugins that also wish to set a CWE for their check.
Maintaining a map is just another bit of maintenance.
Signed-off-by: Eric Brown browne@vmware.com