Re-enable functional tests as part of CI #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericwb
changed the title
Currently our CI is only running the unit tests of Bandit found in tests/unit/*. However, much of the testing of Bandit occurs as part of the functional tests in tests/functional/* that uses the examples to test our many of the plugins. This patch changes the stestr to use a test path in a parent directory of unit and functional so that both are exercises as part of the CI run. This will effectively run against each version of Python too. http://stestr.readthedocs.io/en/latest/MANUAL.html#configuration This patch also repairs the currently broken functional tests. Namely: * ast.TryFinally and ast.TryExcept were removed in Python 3.3+ and replaced with ast.Try - Issue #326 * ast.Call kwargs argument was removed in 3.5 and replaced with keywords - Issue #350 * ast.Call starargs argument was removed in 3.5 and replaced with Starred in args - Issue #351 * ast.NameConstnat is used instead of ast.Name Fixes Issue #326 Fixes Issue #350 Fixes Issue #351 Fixes Issue #353 Signed-off-by: Eric Brown <browne@vmware.com>
ghugo
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our CI is only running the unit tests of Bandit found
in tests/unit/. However, much of the testing of Bandit occurs
as part of the functional tests in tests/functional/* that uses
the examples to test our many of the plugins.
This patch changes the stestr to use a test path in a parent directory
of unit and functional so that both are exercises as part of the CI
run. This will effectively run against each version of Python too.
http://stestr.readthedocs.io/en/latest/MANUAL.html#configuration
This patch also repairs the currently broken functional tests.
Namely:
and replaced with ast.Try - Issue Functional tests are broken #326
keywords - Issue ast.Call kwargs doesn't exist in Python 3.5+ #350
Starred in args - Issue ast.Call starargs argument was removed in Python 3.5+ #351
Fixes Issue #326
Fixes Issue #350
Fixes Issue #351
Fixes Issue #353
Signed-off-by: Eric Brown browne@vmware.com