Add subprocess.run to B602 #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.5 introduced yet another subprocess function, run(). Like the the APIs before it like call(), Popen(), etc it has a shell parameter and can lead to shell injection when used incorrectly. https://docs.python.org/3.5/library/subprocess.html#subprocess.run Signed-off-by: Eric Brown <browne@vmware.com>
ericwb
requested review from
lukehinds,
a team,
ghugo and
sigmavirus24
and removed request for
a team
sigmavirus24
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.5 introduced yet another subprocess function, run(). Like
the the APIs before it like call(), Popen(), etc it has a shell
parameter and can lead to shell injection when used incorrectly.
https://docs.python.org/3.5/library/subprocess.html#subprocess.run
Signed-off-by: Eric Brown browne@vmware.com