Add PyCryptodome to import blacklists #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. We already had blacklisted calls of pycryptodome weak hashes and ciphers, but didn't blacklist the imports themselves. Pycrypto was recently completely blacklisted as an import, so pycryptodome should have been done at the same time. |
ericwb
requested changes
May 16, 2018
PyCryptodome is a direct fork of PyCrypto, and is generally considered to not be the replacement for it. It is recommended that projects move to pyca/cryptography instead, as this may be exposing folks to the same inherent issues that PyCrypto was deprecated because of. Signed-off-by: John 'Warthog9' Hawley <warthog9@eaglescrag.net> Signed-off-by: John 'Warthog9' Hawley <jhawley@vmware.com> Signed-off-by: Terri Oda <terri.oda@intel.com>
warthog9
force-pushed
the
b413_pycryptodome
branch
from
2e80d97 to
f047fda
Compare
|
Rebased, added B414 to README.rst |
ericwb
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyCryptodome is a direct fork of PyCrypto, and is generally
considered to not be the replacement for it. It is recommended
that projects move to pyca/cryptography instead, as this may be
exposing folks to the same inherent issues that PyCrypto was
deprecated because of.
Signed-off-by: John 'Warthog9' Hawley warthog9@eaglescrag.net
Signed-off-by: John 'Warthog9' Hawley jhawley@vmware.com
Signed-off-by: Terri Oda terri.oda@intel.com