Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ODT files support for audiobook as mentioned in issues #57

Merged
merged 6 commits into from
Oct 23, 2022

Conversation

Mr-vabs
Copy link
Contributor

@Mr-vabs Mr-vabs commented Oct 22, 2022

Pull Request Template

script name -

What have you Changed

what you changed in the codebase.write here

I've added support for ODT files. I've tested and it's working fine. In order to make it supported, I've coded in main.py for file format , utils.py for actual logic, and required changes as in requirements.txt.

Issue no.(must) - #46

Self Check(Tick After Making pull Request)

  • This issue was assigned to me.
  • One Change in one Pull Request
  • My file is in proper folder
  • I am following clean code and Documentation and my code is well linted with flake8.
  • I have added README.md and requirements.txt with my script

If issue was not assigned to you Please don't make a PR. It will marked as invalid.

Join Us on Discord:- https://discord.gg/JfbK3bS

@DrakeEntity
Copy link
Contributor

@Mr-vabs There are some bugs in your code. Please try to fix them

@DrakeEntity
Copy link
Contributor

DrakeEntity commented Oct 22, 2022

you can find more details in the code analysis workflow. we have implemented some code analysis work flow for clean and quality code.

Copy link
Member

@hot9cups hot9cups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to this and this to locate your bugs and fix them.
You could also try and setup flake8 locally to have avoided the linting errors even before having raised the PR.

@codeperfectplus
Copy link
Member

I have deeply reviewed the code, so the issue is you are creating the same variable name as imported from ODF.

try to change the text variable in line number 109, 111, 114, and 116. It will solve the issue. Suggested variable name output_txt or odf_output. you can also decide by yourself.

@Mr-vabs
Install flake8 on your local and run the below flake8 command, the same command is running on the server.

pip install flake8
flake8 . --isolated --exclude=.cache,.venv,.svn,CVS,.bzr,.hg,.git,__pycache__,.tox,**/migrations/** --ignore=E203,W503,E501,F401

@hot9cups thanks for your feedback.

@codeperfectplus codeperfectplus linked an issue Oct 22, 2022 that may be closed by this pull request
@hot9cups
Copy link
Member

No problem @codeperfectplus , happy to help.

@codeperfectplus codeperfectplus added enhancement New feature or request hacktoberfest-accepted Hacktober issue ready-for-review this pr is ready for review labels Oct 23, 2022
@DrakeEntity DrakeEntity merged commit ae12612 into Py-Contributors:dev Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted Hacktober issue ready-for-review this pr is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support: ODT file support adding
4 participants