Bugfix/validation fixes #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced abstract BinaryDataReader base class and static factory - Added Create method for codec-based instantiation - Moved submap index logic to IMatrixMap.GetIndicesOfSubmap extension - Updated BinaryDataReader to use new index mapping and relative seeking - Added unit tests for submap index mapping - Refactored test streams and improved test assertions
Add streamDataStartLinearIndex to BinaryDataReader to support reading from streams already positioned at any data index, not just at the header start. Update offset logic and add validation for negative indices. Expand tests to cover seekable and non-seekable streams at various positions, and add a helper for test stream setup.
Renamed the streamDataStartLinearIndex parameter to streamDataPositionIndex across BinaryDataReader and related tests for clarity and consistency. Added a ByteCount abstract property to BinaryDataReaderStatic and implemented it in BinaryDataReader to expose the encoded value size. Introduced a new ReadFromStreamAsync overload with the updated parameter.
- Add XML docs and clarify method signatures in BinaryDataReader - Add argument validation for stream position and target index - Add unit test for out-of-range stream read scenario - Update README with binary reader usage and codec info - Revert project version to 1.3.1 in csproj
Added unit tests for BinaryDataReader.Create covering type creation and error handling. Improved comments and XML docs for clarity in stream logic and delegate return types.
… data read benchmarks for comparison, union and intersection matrix map methods
… read last matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.