Reorder preprocessor conditions in libi2pd/I2PEndian.h #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem is that __FreeBSD_kernel__ may be defined on FreeBSD as well, while it always needs <sys/endian.h>
|
Thanks! Please note the suggestion in PR description. |
|
FreeBSD_kernel check was not implemented bt me, but kytv I believe. That's about debian with freebsd's kernel |
|
He has left I2P almost 2 years ago |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that FreeBSD_kernel may be defined on FreeBSD as
well, while it always needs <sys/endian.h>
In fact, you shouldn't check for FreeBSD_kernel at all, as the code has nothing to do with whether the code runs under FreeBSD kernel or not.