Change default theme from PolyPilotDark to System#150
Merged
Conversation
The app defaulted to the dark theme regardless of OS preference. Change the default UiTheme from PolyPilotDark to System so the app follows the OS light/dark setting out of the box. The CSS already handles the system theme via prefers-color-scheme media queries.
Collaborator
Author
|
Starting with the important stuff... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app defaulted to the dark theme (
UiTheme.PolyPilotDark) regardless of the OS preference. This changes the default toUiTheme.Systemso the app follows the OS light/dark setting out of the box.Changes
Themeproperty changed fromUiTheme.PolyPilotDarktoUiTheme.SystemThemeproperty changed fromUiTheme.PolyPilotDarktoUiTheme.SystemNo CSS changes needed — the
[data-theme="system"]selector with@media (prefers-color-scheme: light)rules already exists inapp.css.Users who previously saved settings will keep their chosen theme; only new installs (or fresh settings) are affected.