Open
Conversation
irvingywang
reviewed
Jan 30, 2026
Member
|
also your PR failed the CI check. |
Collaborator
Format check failed |
LelsersLasers
requested changes
Jan 30, 2026
src/app.rs
Outdated
| pub theme: egui::Style, | ||
| pub theme_selection: ThemeSelection, | ||
| pub pixels_per_point: f32, | ||
| pub logo_texture: Option<egui::TextureHandle>, |
Collaborator
There was a problem hiding this comment.
I am reviewing this from a plane on my phone so this may be a really dumb comment but:
Does the logo need to be an option? If it is loaded on the creation of the App, it will always be Some and then you can drop the Option?
Member
|
u have a conflict with main pls resolve that first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PER logo and widget icon