Conversation
…nd improve contrast
There was a problem hiding this comment.
PR Overview
This PR modernizes the Dullahan VS Code theme by migrating the codebase to TypeScript and introducing enhanced UI and semantic token features. Key changes include a modular structure for theme generation, comprehensive new color and token definitions, and updated CI/CD workflows to support the new build process.
Reviewed Changes
| File | Description |
|---|---|
| eslint.config.mjs | Added ESLint configuration with FlatCompat and simple import sorting rules. |
| src/index.ts | Implements theme generation for dark, golden, and white themes and writes them to files. |
| CONTRIBUTING.md | Updates contributing guidelines and project structure information. |
| src/colors/index.ts | Exports new color definitions. |
| src/semantic-colors/*.ts | Adds semantic color definitions for dark, golden, and white themes. |
| .prettierrc.yaml | Introduces Prettier configuration with packagejson plugin. |
| src/generate-theme.ts | Adds TypeScript-typed theme generation helper. |
| src/colors/dark.ts, golden.ts, white.ts | Provides comprehensive color definitions for each theme variant. |
| src/token-colors/dark.ts | Introduces token color definitions for various languages. |
| .github/workflows/ci.yml | Updates CI workflow steps and cache configuration. |
| .github/workflows/cd.yml | Updates CD workflow steps and extension publishing versions. |
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:17
- The key 'SCOPRE_OWNER' appears to be misspelled. Consider renaming it to 'SCOPE_OWNER' for clarity.
SCOPRE_OWNER: '@pungrumpy'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes the Dullahan VSCode theme with a complete TypeScript refactoring and significant feature improvements to bring it up to date with current best practices and UI requirements.
🔄 Code Refactoring
src/types/for TypeScript type definitionssrc/colors/for UI colorssrc/token-colors/for syntax highlightingsrc/semantic-colors/for semantic token coloring✨ New Features
🖌️ Theme Improvements
📚 Documentation