-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implement execute-dir
#184
base: main
Are you sure you want to change the base?
Conversation
This works well enough for my purposes - what would be needed to get it over the finish line? |
Thanks for looking into this @asinghvi17.
Some tests to verify the new behaviour will be needed. |
if ed == "directory" | ||
cd(dirname(path)) | ||
elseif ed == "project" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only see a description of project
here, https://quarto.org/docs/projects/code-execution.html#working-dir, not directory
. Is that documented elsewhere. It also doesn't mention that you can pass a path, is that described somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just looked this up - Quarto's project file schema defines execute-dir
as an enum: [file, project]
, so we should probably only support those two arguments.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
==========================================
- Coverage 51.40% 50.96% -0.45%
==========================================
Files 30 30
Lines 1280 1295 +15
==========================================
+ Hits 658 660 +2
- Misses 622 635 +13 ☔ View full report in Codecov by Sentry. |
This PR implements the
execute-dir
option inproject
, bycd
'ing to the appropriate directory on refresh.TODOs: