Mux.Handler: prioritize most specific match #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Path matches still take priority, but ties are broken with the number of additional matching criteria.
mna
requested changes
Mar 20, 2020
Member
mna
left a comment
mna
left a comment
There was a problem hiding this comment.
I think the intention makes sense, but could you add tests that verify the correct behaviour, including the edge cases (same path length, same number of criteria)?
Co-Authored-By: Martin Angers <martin.n.angers@gmail.com>
Contributor
Author
|
Sense you like the change I'll add a few tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path matches still take priority, but ties are broken with the number of
additional matching criteria.
fix #32