chore(lint): anti-slop rungs 4+5 — enable no-unknown-returns and no-chained-type-assertions, fix 73+126 violations

.oxlintrc.json

@@ -70,7 +70,7 @@
 		"publy/no-manual-response-message-translation": "error",
 		"publy/arrow-function-components": "error",
 		"publy/prefer-query-display": "error",
-		"anti-slop/no-chained-type-assertions": "off",
+		"anti-slop/no-chained-type-assertions": "error",
 		"anti-slop/no-conditional-empty-object-spread": "error",
 		"anti-slop/no-known-value-widening": "off",
 		"anti-slop/no-module-mocking": "off",
@@ -80,7 +80,7 @@
 		"anti-slop/no-runtime-typeof": "off",
 		"anti-slop/no-shape-in-symbol-names": "error",
 		"anti-slop/no-unknown-parameters": "off",
-		"anti-slop/no-unknown-returns": "off",
+		"anti-slop/no-unknown-returns": "error",
 		"anti-slop/no-unknown-type-aliases": "error",
 		"anti-slop/no-unsafe-dictionary-type": "off",
 		"anti-slop/no-widen-then-assert": "error",

apps/front/e2e/auth-error.spec.ts

@@ -522,7 +522,7 @@ test.describe(
 			await expect(page.getByTestId('view-404')).toBeVisible();
 
 			await page.evaluate(() => {
-				(window as unknown as { __spaAlive?: boolean }).__spaAlive = true;
+				(window as { __spaAlive?: boolean } & typeof window).__spaAlive = true;
 			});
 			await page
 				.getByTestId('view-404')
@@ -531,7 +531,8 @@ test.describe(
 
 			const alive = await page.evaluate(
 				() =>
-					(window as unknown as { __spaAlive?: boolean }).__spaAlive === true,
+					(window as { __spaAlive?: boolean } & typeof window).__spaAlive ===
+					true,
 			);
 			expect(alive).toBe(true);
 		});

apps/front/e2e/parity-happy-path.spec.ts

@@ -74,7 +74,7 @@ const getThemeState = async (page: Page) =>
 	}));
 
 const extractSeededEmails = async (response: {
-	json: () => Promise<unknown>;
+	json: () => Promise<{ data?: unknown }>;
 }): Promise<string[]> => {
 	const payload = (await response.json()) as {
 		data?: unknown;
@@ -97,7 +97,7 @@ const mapRowsEmails = (rows: unknown[]): string[] => {
 };
 
 const extractProfiles = async (response: {
-	json: () => Promise<unknown>;
+	json: () => Promise<{ data?: unknown }>;
 }): Promise<StaffProfileFixture[]> => {
 	const payload = (await response.json()) as {
 		data?: unknown;

apps/front/e2e/staff-profiles.spec.ts

@@ -34,7 +34,7 @@ const waitForStaffProfilesGetResponse = (page: Page, expectedQuery?: string) =>
 	});
 
 const extractProfiles = async (response: {
-	json: () => Promise<unknown>;
+	json: () => Promise<{ data?: unknown }>;
 }): Promise<StaffProfileFixture[]> => {
 	const payload = (await response.json()) as {
 		data?: unknown;

apps/front/e2e/staff-tenant-details.spec.ts

@@ -270,7 +270,7 @@ test.describe(
 			await expect(page.getByTestId('staff-tenant-details-page')).toBeVisible();
 
 			await page.evaluate(() => {
-				(window as unknown as { __spaAlive?: boolean }).__spaAlive = true;
+				(window as { __spaAlive?: boolean } & typeof window).__spaAlive = true;
 			});
 
 			await page.getByRole('link', { name: 'Users' }).click();
@@ -282,7 +282,8 @@ test.describe(
 
 			const alive = await page.evaluate(
 				() =>
-					(window as unknown as { __spaAlive?: boolean }).__spaAlive === true,
+					(window as { __spaAlive?: boolean } & typeof window).__spaAlive ===
+					true,
 			);
 			expect(alive).toBe(true);
 		});

apps/front/e2e/toast-contrast.spec.ts

@@ -298,21 +298,15 @@ const readBrowserPaint = async (
 					earlyAssert(
 						{
 							backgroundClip: ps.backgroundClip,
-							webkitBackgroundClip: (
-								ps as unknown as Record<string, string | undefined>
-							)['webkitBackgroundClip'],
-							webkitTextFillColor: (
-								ps as unknown as Record<string, string | undefined>
-							)['webkitTextFillColor'],
+							webkitBackgroundClip:
+								ps.getPropertyValue('-webkit-background-clip') || undefined,
+							webkitTextFillColor:
+								ps.getPropertyValue('-webkit-text-fill-color') || undefined,
 							color: ps.color,
 							opacity: ps.opacity,
-							maskImage: (ps as unknown as Record<string, string | undefined>)[
-								'maskImage'
-							],
-							mask: (ps as unknown as Record<string, string | undefined>)[
-								'mask'
-							],
-						} as Record<string, string | undefined>,
+							maskImage: ps.getPropertyValue('mask-image') || undefined,
+							mask: ps.getPropertyValue('mask') || undefined,
+						},
 						label,
 					);
 					for (
@@ -1242,21 +1236,18 @@ const readBrowserPaint = async (
 					evaluateClassifier(
 						{
 							backgroundClip: painterStyle.backgroundClip,
-							webkitBackgroundClip: (
-								painterStyle as unknown as Record<string, string | undefined>
-							)['webkitBackgroundClip'],
-							webkitTextFillColor: (
-								painterStyle as unknown as Record<string, string | undefined>
-							)['webkitTextFillColor'],
+							webkitBackgroundClip:
+								painterStyle.getPropertyValue('-webkit-background-clip') ||
+								undefined,
+							webkitTextFillColor:
+								painterStyle.getPropertyValue('-webkit-text-fill-color') ||
+								undefined,
 							color: painterStyle.color,
 							opacity: painterStyle.opacity,
-							maskImage: (
-								painterStyle as unknown as Record<string, string | undefined>
-							)['maskImage'],
-							mask: (
-								painterStyle as unknown as Record<string, string | undefined>
-							)['mask'],
-						} as Record<string, string | undefined>,
+							maskImage:
+								painterStyle.getPropertyValue('mask-image') || undefined,
+							mask: painterStyle.getPropertyValue('mask') || undefined,
+						},
 						painterName,
 					);
 					// Walk ancestors for opacity:0 — text inherits invisibility even if painter itself is opaque
@@ -1279,9 +1270,7 @@ const readBrowserPaint = async (
 						);
 					}
 					toSrgb(
-						(painterStyle as unknown as Record<string, string | undefined>)[
-							'webkitTextFillColor'
-						] || painterStyle.color,
+						painterStyle.webkitTextFillColor || painterStyle.color,
 						`${painterName} text fill colour`,
 					);
 				}
@@ -1502,7 +1491,7 @@ const measurePaintedContrast = async (
 			const canvas = {
 				width: __publyImageData.width,
 				height: __publyImageData.height,
-			} as unknown as HTMLCanvasElement;
+			} as HTMLCanvasElement;
 			const data = __publyImageData.data;
 
 			const luminance = ([r, g, b]: number[]): number => {

apps/front/src/components/app-shell/app-shell.test.tsx

@@ -40,7 +40,9 @@ vi.mock('@tanstack/react-router', () => ({
 	}) => {
 		const resolvedSearch =
 			typeof search === 'function'
-				? (search as (prev: unknown) => unknown)(mocks.linkPrevSearch)
+				? (search as (prev: unknown) => Record<string, unknown>)(
+						mocks.linkPrevSearch,
+					)
 				: search;
 		return createElement(
 			'a',
@@ -55,7 +57,7 @@ vi.mock('@tanstack/react-router', () => ({
 			children,
 		);
 	},
-	useMatches: ({ select }: { select: (matches: unknown[]) => unknown }) =>
+	useMatches: ({ select }: { select: (matches: unknown[]) => void }) =>
 		select(mocks.matches),
 }));
 

apps/front/src/components/marketing/marketing.test-helper.tsx

@@ -82,5 +82,5 @@ export const renderMarketing = async (
 		}
 	});
 
-	return { ...result, router: router as unknown as AnyRouter };
+	return { ...result, router: router as AnyRouter };
 };

apps/front/src/components/ui/drawer-form.test.tsx

@@ -180,6 +180,7 @@ import type { AnyNode, AtRule, Rule } from 'postcss';
 import { createElement, type ReactNode } from 'react';
 import { useForm } from 'react-hook-form';
 import {
+	Node,
 	Project,
 	SyntaxKind,
 	ts,
@@ -192,6 +193,7 @@ import {
 	type CaseClause,
 	type CatchClause,
 	type ConditionalExpression,
+	type ElementAccessExpression,
 	type FunctionDeclaration,
 	type GetAccessorDeclaration,
 	type IfStatement,
@@ -204,7 +206,6 @@ import {
 	type JsxSelfClosingElement,
 	type LabeledStatement,
 	type MethodDeclaration,
-	type Node,
 	type ObjectLiteralExpression,
 	type PrefixUnaryExpression,
 	type PropertyAccessExpression,
@@ -6189,11 +6190,7 @@ const isTracedArrayLiteralUnsafe = (
 					}
 					if (prop.getKind() === SyntaxKind.SpreadAssignment) {
 						return argumentReferencesTracedArray(
-							(
-								prop as unknown as {
-									getExpression(): Node;
-								}
-							).getExpression(),
+							prop.asKindOrThrow(SyntaxKind.SpreadAssignment).getExpression(),
 						);
 					}
 					return false;
@@ -6257,11 +6254,7 @@ const isTracedArrayLiteralUnsafe = (
 			const left = binaryExpression.getLeft();
 			if (left.getKind() === SyntaxKind.ElementAccessExpression) {
 				const elementBase = unwrapExpression(
-					(
-						left as unknown as {
-							getExpression(): Node;
-						}
-					).getExpression(),
+					(left as ElementAccessExpression).getExpression(),
 				);
 				if (writesToTracedArray(elementBase)) {
 					return true;
@@ -6664,9 +6657,9 @@ const classifyObjectLiteralReference = (
 			continue;
 		}
 		if (prop.getKind() === SyntaxKind.SpreadAssignment) {
-			const argument = (
-				prop as unknown as { getExpression(): Node }
-			).getExpression();
+			const argument = prop
+				.asKindOrThrow(SyntaxKind.SpreadAssignment)
+				.getExpression();
 			if (!argument) {
 				anyUnresolved = true;
 				continue;
@@ -8209,15 +8202,13 @@ const collectStatementReturns = (
 			continue;
 		}
 		if (
-			kind === SyntaxKind.ForStatement ||
-			kind === SyntaxKind.ForInStatement ||
-			kind === SyntaxKind.ForOfStatement ||
-			kind === SyntaxKind.WhileStatement ||
-			kind === SyntaxKind.DoStatement
+			Node.isForStatement(statement) ||
+			Node.isForInStatement(statement) ||
+			Node.isForOfStatement(statement) ||
+			Node.isWhileStatement(statement) ||
+			Node.isDoStatement(statement)
 		) {
-			const loopBody = (
-				statement as unknown as { getStatement(): Statement }
-			).getStatement();
+			const loopBody = statement.getStatement();
 			const loopCollected = collectStatementReturns(asStatementList(loopBody));
 			if (loopCollected === null) {
 				return null;

apps/front/src/i18n/locales/locales.test.ts

@@ -116,18 +116,8 @@ const marketingCopy = (bundle: {
 	landing: Record<string, string>;
 }): Record<string, string> => ({ ...bundle.common, ...bundle.landing });
 
-const enMarketing = marketingCopy(
-	en as unknown as {
-		common: Record<string, string>;
-		landing: Record<string, string>;
-	},
-);
-const frMarketing = marketingCopy(
-	fr as unknown as {
-		common: Record<string, string>;
-		landing: Record<string, string>;
-	},
-);
+const enMarketing = marketingCopy(en);
+const frMarketing = marketingCopy(fr);
 
 describe('front locale manifests', () => {
 	test('publish every registered namespace in registry order', () => {

apps/front/src/lib/i18n/trans-render.guard.test.tsx

@@ -200,7 +200,7 @@ describe('real-<Trans> render guard (#1269)', () => {
 			'Trans must be the real react-i18next component, not a vi.fn',
 		).toBe(false);
 		expect(
-			(initReactI18next as unknown as { type?: string }).type,
+			(initReactI18next as { type?: string }).type,
 			'initReactI18next must be the real react-i18next plugin object',
 		).toBe('3rdParty');
 	});

apps/front/src/lib/locale-switch.ts

@@ -4,10 +4,12 @@ import {
 	postBroadcast,
 } from '~/lib/tab-sync/broadcast-sync';
 
-type RouterLike = { invalidate: () => Promise<unknown> };
+type LocaleSwitchedResult = { locale: SupportedLanguage };
+
+type RouterLike = { invalidate: () => Promise<void> };
 type SetLocaleFn = (opts: {
 	data: { locale: SupportedLanguage };
-}) => Promise<unknown>;
+}) => Promise<LocaleSwitchedResult>;
 
 /**
  * Re-runs the root loader so it re-resolves `{ locale, resources }` from the

apps/front/src/lib/navigation/breadcrumb-contract.test.tsx

@@ -167,7 +167,7 @@ const buildSyntheticParams = (segments: string[]): Record<string, string> => {
  */
 type EntityRegistryEntry = {
 	query: (params: Record<string, string>) => EntityCrumbQuery;
-	buildPayload: (marker: string) => unknown;
+	buildPayload: (marker: string) => Record<string, unknown>;
 };
 
 const ENTITY_QUERY_REGISTRY: readonly EntityRegistryEntry[] = [
@@ -245,7 +245,7 @@ const ENTITY_QUERY_REGISTRY: readonly EntityRegistryEntry[] = [
 createRouter({ routeTree, history: createMemoryHistory() } as never);
 
 describe('breadcrumb contract — route-tree walk (#973 Tier 2, guard A)', () => {
-	const allRoutes = walkRealRouteTree(routeTree as unknown as RouteLike);
+	const allRoutes = walkRealRouteTree(routeTree as RouteLike);
 
 	test('the walk is not vacuous: it visits as many routes as the virtual route config declares', () => {
 		const expectedCount = countVirtualRouteNodes(routes);
@@ -535,17 +535,31 @@ describe('breadcrumb contract — route-tree walk (#973 Tier 2, guard A)', () =>
  */
 type FakeClientCall = { path: readonly string[]; args: readonly unknown[] };
 
+/** Whatever the fake Kiota chain resolves to — tests read it back through
+ * `respond` mock assertions, never by consuming the value itself. */
+type FakeResponse = Record<string, unknown>;
+
+/** One link in the fake Kiota method chain — a callable Proxy whose
+ * properties continue the chain and whose call resolves an HTTP verb
+ * segment. Declared as an interface because the index signature points
+ * back at the same type (a self-referencing type alias is circular). */
+interface FakeApiClient {
+	(): Promise<FakeResponse>;
+	[segment: string]: FakeApiClient;
+}
+
 const mocks = vi.hoisted(() => {
 	const HTTP_VERBS = new Set(['get', 'post', 'patch', 'delete', 'put']);
 
 	/** A generic stand-in for the Kiota-generated `ApiClient`: every property
 	 * access continues the method chain (`.staff.tenants.byTenantId(id)`),
 	 * and calling a chain whose last segment is an HTTP verb resolves via
 	 * `respond`. */
+
 	const buildFakeApiClient = (
-		respond: (call: FakeClientCall) => unknown,
-	): unknown => {
-		const makeProxy = (path: readonly string[]): unknown =>
+		respond: (call: FakeClientCall) => FakeResponse | Promise<FakeResponse>,
+	): FakeApiClient => {
+		const makeProxy = (path: readonly string[]): FakeApiClient =>
 			new Proxy(() => {}, {
 				get: (_target, prop) =>
 					typeof prop === 'string' ? makeProxy([...path, prop]) : undefined,
@@ -559,12 +573,14 @@ const mocks = vi.hoisted(() => {
 					// at the same logical position so `.get()` can follow.
 					return makeProxy(path);
 				},
-			});
+			}) as FakeApiClient;
 
 		return makeProxy([]);
 	};
 
-	const respond = vi.fn((_call: FakeClientCall): unknown => ({}));
+	const respond = vi.fn(
+		(_call: FakeClientCall): FakeResponse | Promise<FakeResponse> => ({}),
+	);
 	const fakeClient = buildFakeApiClient((call) => respond(call));
 
 	return { respond, fakeClient };