Extract tests - adding cost uplift for PLICS inflation #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizihao-anu
reviewed
Sep 23, 2025
lizihao-anu
reviewed
Sep 23, 2025
Collaborator
Author
|
Hi Zihao, I have reviewed the feedback and re-wrote the code to avoid duplication as much as possible. @lizihao-anu |
lizihao-anu
approved these changes
Sep 23, 2025
Collaborator
lizihao-anu
left a comment
lizihao-anu
left a comment
There was a problem hiding this comment.
I have tested and the code looks great!
Although the checks passed, I noticed the document.yaml workflow was failing on the smr-cost-uplift branch. It looks like this issue is also present in the master and dec25-update branches when I checked the document workflow in the actions tab for those branches too. I inspected the error and it was a git push rejection. This happened because the workflow's automated git-auto-commit-action tried to push documentation updates, but the remote branch on GitHub already had newer commits. To fix this, I've committed a change to the document.yaml workflow. The solution was to add a step to git pull the latest changes from the remote branch before the auto-commit action runs. This ensures the workflow is always working on the most up-to-date version of the branch and can push its changes without conflict. The workflow should now run and pass correctly. Let me know if you have any questions.
Reverting changes as it failed because of an overall changed workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a function to uplift costs at extract stage. Applied the uplift to relevant recids (00B, 01B, 02B, 04B, AE2).