-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean test folder #1021
base: december-2024
Are you sure you want to change the base?
Clean test folder #1021
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi, is it ready for review? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @lizihao-anu I've pushed some changes and this is now ready for review. I've updated this so that it will produce the output only once per quarterly update. Thanks |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (1)SPSS These words are not needed and should be removedanomymous datas scoial spssTo accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/11820948999/attempts/1'
OR To have the bot accept them for you, comment in the PR quoting the following line: Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (313) from .github/actions/spelling/expect.txt and unrecognized words (1)
Consider adding them (in with:
extra_dictionaries: |
cspell:fullstack/dict/fullstack.txt
cspell:k8s/dict/k8s.txt
cspell:php/dict/php.txt
cspell:node/dict/node.txt
cspell:npm/dict/npm.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' Pattern suggestions ✂️ (1)You could add these patterns to
Errors (2)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
@@ -10,6 +116,7 @@ latest_update <- function() { | |||
"Sep_2024" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could automate this using end_date
#' | ||
#' @family initialisation | ||
get_dd_period <- function() { | ||
"Jul16_Jun24" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could also automate this - will add an issue for both
I've cleaned out the tests folder and updated the file paths accordingly. Should now be a bit more automated and also all tests are in the same naming convention. E.g.
Sep_2024_2021_ep_file_tests
orSep_2024_2021_extract_tests
. I zipped up 2023 tests with the idea that we should archive/zip tests once we have a full year availableOpening as a draft for now as still outstanding:
Still TO DO: