Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Remove Unused Vars #9

Merged
merged 26 commits into from
Nov 30, 2020
Merged

Updates to Remove Unused Vars #9

Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e9721c8
updates for first cut at bidder
GLStephen Nov 12, 2020
0277aca
fix up height and width
GLStephen Nov 13, 2020
9161810
adds test spec
GLStephen Nov 15, 2020
a2f4946
remove hello_world from commit'
GLStephen Nov 15, 2020
7700d9b
updates to support native and fix issues found in initial review
GLStephen Nov 22, 2020
39e2228
fix handling of new node in response for native vs banner
GLStephen Nov 23, 2020
860b1cc
updates to handle OpenRTB base
GLStephen Nov 25, 2020
3a1607e
updates to support RTB style calls
GLStephen Nov 25, 2020
2b9de0d
updates to get back to parity
GLStephen Nov 25, 2020
fde493a
updates to testing
GLStephen Nov 25, 2020
d49be62
updates to test media type handling
GLStephen Nov 25, 2020
ba548b7
:Merge branch 'external-pw-481' of github.com:PubWise/Prebid.js into …
GLStephen Nov 25, 2020
28d4b7c
updates to handling testing
GLStephen Nov 25, 2020
62c3007
updates to testing
GLStephen Nov 28, 2020
c10b9a7
remove report file
GLStephen Nov 28, 2020
25f9df4
updates to fix up unit/spec tests
GLStephen Nov 28, 2020
6cbd498
updates to fix up unit/spec tests
GLStephen Nov 28, 2020
bd8c7a7
updates to fix up unit/spec tests
GLStephen Nov 28, 2020
c0396fe
updates to handling of gdpr
GLStephen Nov 28, 2020
bec22f1
Delete hello_world.html
GLStephen Nov 28, 2020
2c8c3c6
remove hellow-world-sample
GLStephen Nov 28, 2020
7484100
remove hellow-world-sample
GLStephen Nov 28, 2020
48889f7
updates to fix param tes
GLStephen Nov 29, 2020
6b835f3
fix merge
GLStephen Nov 29, 2020
48167c1
remove unused variables and params
GLStephen Nov 30, 2020
31964df
Merge branch 'external-pw-481' of github.com:PubWise/Prebid.js into p…
GLStephen Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions modules/pubwiseBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,19 +503,10 @@ function _parseSlotParam(paramName, paramValue) {
function _parseAdSlot(bid) {
_logInfo('parseAdSlot bid', bid)
bid.params.adUnit = '';
bid.params.adUnitIndex = '0';
bid.params.width = 0;
bid.params.height = 0;
bid.params.adSlot = _cleanSlotName(bid.params.adSlot);

var slot = bid.params.adSlot;
var splits = slot.split(':');

slot = splits[0];
if (splits.length == 2) {
bid.params.adUnitIndex = splits[1];
}

if (bid.hasOwnProperty('mediaTypes')) {
if (bid.mediaTypes.hasOwnProperty(BANNER) &&
bid.mediaTypes.banner.hasOwnProperty('sizes')) { // if its a banner, has mediaTypes and sizes
Expand Down