Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UOE-11371: Wakanda Data is not logged if logger is disabled using publisher feature. #942

Open
wants to merge 2 commits into
base: ci
Choose a base branch
from

Conversation

pm-priyanka-bagade
Copy link
Collaborator

No description provided.

*orignalMaxBidResponse = *ao.Response
}
var loggerURL string
var headers http.Header
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move var headers http.Header inside the if block.

}
var loggerURL string
var headers http.Header
if !rCtx.LoggerDisabled {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a UT for following scenarios?

  1. Logger is Disabled and Wakanda is enabled for AppLovin Endpoint.
  2. Logger is Disabled and Wakanda is enabled for Some other endpoint Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants