UOE-11098: Pass user.ext.sessionduration and user.ext.impdepth ORTB request to OW partners #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e not consuming PublisherID Configured at Partner Account Level (#885)
…rap module (#874) * OTT-1807: discard emptyVAST and invalidVAST bids
OTT-1824: using fastxml for video event injection
…jetc from the signal regs.ext (#893)
Downmerge Master to Ci
RE-3733: Release 12th_Sept_2024
Downmerge 12th September release
* stat for bid recovery * change buckets * introduce new stat
…equest to OW partners
Pubmatic-Supriya-Patil
changed the title
…ider positive value
| // ORTBUserExtSessionDuration will read and set ortb User.Ext.sessionduration parameter | ||
| func (o *OpenRTB) ORTBUserExtSessionDuration() (err error) { | ||
| valStr, ok := o.values.GetString(ORTBUserExtSessionDuration) | ||
| if !ok { |
There was a problem hiding this comment.
Can change this to
if !ok || valStr == ""{ returned nil }
| } | ||
| } | ||
|
|
||
| if valStr != "" { |
There was a problem hiding this comment.
Can we remove this check and move it in the first if block?
| } | ||
| userExt := map[string]interface{}{} | ||
| if o.ortb.User.Ext != nil { | ||
| err = json.Unmarshal(o.ortb.User.Ext, &userExt) |
There was a problem hiding this comment.
if err = json.Unmarshal(o.ortb.User.Ext, &userExt); err != nil {
return
}
Comment on lines
4547
to
4578
| func (o *OpenRTB) ORTBUserExtImpDepth() (err error) { | ||
| valStr, ok := o.values.GetString(ORTBUserExtImpDepth) | ||
| if !ok { | ||
| return | ||
| } | ||
| if o.ortb.User == nil { | ||
| o.ortb.User = &openrtb2.User{} | ||
| } | ||
| userExt := map[string]interface{}{} | ||
| if o.ortb.User.Ext != nil { | ||
| err = json.Unmarshal(o.ortb.User.Ext, &userExt) | ||
| if err != nil { | ||
| return | ||
| } | ||
| } | ||
| if valStr != "" { | ||
| val, err := strconv.ParseUint(valStr, 10, 64) | ||
| if err != nil { | ||
| logger.Warn("Invalid imp depth value '%v': %v", valStr, err) | ||
| return nil | ||
| } | ||
| userExt[ORTBExtImpDepth] = int64(val) | ||
| } | ||
|
|
||
| data, err := json.Marshal(userExt) | ||
| if err != nil { | ||
| return | ||
| } | ||
|
|
||
| o.ortb.User.Ext = data | ||
| return | ||
| } |
There was a problem hiding this comment.
Same comments as above
| @@ -48,7 +49,15 @@ func UpdateUserEidsWithValidValues(user *openrtb2.User) { | |||
| if err != nil { | |||
| return | |||
| } | |||
| if userExt.SessionDuration < 0 { | |||
There was a problem hiding this comment.
Can we change the type of SessionDuration and ImpDepth to uint instead of having these checks?
pm-viral-vala
force-pushed
the
ci
branch
3 times, most recently
from
1eadcd8
to
bcc32d1
Compare
Code coverage summaryNote:
vastbidderRefer here for heat map coverage report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass user.ext.sessionduration and user.ext.impdepth ORTB request to OW partners