Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTT-1688: Get ad rule configuration from the adunit config and update the bid request #743

Open
wants to merge 4 commits into
base: ci_backup_20240416
Choose a base branch
from
Open

OTT-1688: Get ad rule configuration from the adunit config and update the bid request #743

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6b6208
OTT-1688: Get ad rule configuration from the adunit config and update…
Pubmatic-Supriya-Patil Apr 4, 2024
3766b95
OTT-1688: Update video type to openrtb2
Pubmatic-Supriya-Patil Apr 4, 2024
f7b4ae1
Merge branch 'ci' of github.com:PubMatic-OpenWrap/prebid-server into …
Pubmatic-Supriya-Patil Apr 10, 2024
fb81b38
Merge branch 'ci' of github.com:PubMatic-OpenWrap/prebid-server into …
Pubmatic-Supriya-Patil Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions modules/pubmatic/openwrap/models/adunitconfig/adunitconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,15 @@ type AdConfig struct {
BidFloorCur *string `json:"bidfloorcur,omitempty"`
Floors *openrtb_ext.PriceFloorRules `json:"floors,omitempty"`

Exp *int `json:"exp,omitempty"`
Banner *Banner `json:"banner,omitempty"`
Native *Native `json:"native,omitempty"`
Video *Video `json:"video,omitempty"`
App *openrtb2.App `json:"app,omitempty"`
Device *openrtb2.Device `json:"device,omitempty"`
Transparency *Transparency `json:"transparency,omitempty"`
Regex *bool `json:"regex,omitempty"`
UniversalPixel []UniversalPixel `json:"universalpixel,omitempty"`
EnableGAMUrlLookup bool `json:"enablegamurllookup,omitempty"`
Exp *int `json:"exp,omitempty"`
Banner *Banner `json:"banner,omitempty"`
Native *Native `json:"native,omitempty"`
Video *Video `json:"video,omitempty"`
Adrule []*openrtb2.Video `json:"adrule,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pubmatic-Supriya-Patil : For now its looks good. But, in longer run, we may need to support multiple ad rules in longer run.

App *openrtb2.App `json:"app,omitempty"`
Device *openrtb2.Device `json:"device,omitempty"`
Transparency *Transparency `json:"transparency,omitempty"`
Regex *bool `json:"regex,omitempty"`
UniversalPixel []UniversalPixel `json:"universalpixel,omitempty"`
EnableGAMUrlLookup bool `json:"enablegamurllookup,omitempty"`
}
Loading