forked from prebid/prebid-server
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTT-1688: Get ad rule configuration from the adunit config and update the bid request #743
Open
Pubmatic-Supriya-Patil
wants to merge
4
commits into
ci_backup_20240416
Choose a base branch
from
OTT-1688
base: ci_backup_20240416
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a6b6208
OTT-1688: Get ad rule configuration from the adunit config and update…
Pubmatic-Supriya-Patil 3766b95
OTT-1688: Update video type to openrtb2
Pubmatic-Supriya-Patil f7b4ae1
Merge branch 'ci' of github.com:PubMatic-OpenWrap/prebid-server into …
Pubmatic-Supriya-Patil fb81b38
Merge branch 'ci' of github.com:PubMatic-OpenWrap/prebid-server into …
Pubmatic-Supriya-Patil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pubmatic-Supriya-Patil : For now its looks good. But, in longer run, we may need to support multiple ad rules in longer run.