OTT-1902: Log bad request when loglevel is debug (#838)

PubMatic-OpenWrap · Jul 10, 2024 · 31e0be3 · 31e0be3
1 parent a007d3d
commit 31e0be3
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 6 deletions.
diff --git a/modules/pubmatic/openwrap/beforevalidationhook.go b/modules/pubmatic/openwrap/beforevalidationhook.go
@@ -57,6 +57,11 @@ func (m OpenWrap) handleBeforeValidationHook(
 			if rCtx.IsCTVRequest {
 				m.metricEngine.RecordCTVInvalidReasonCount(getPubmaticErrorCode(openrtb3.NoBidReason(result.NbrCode)), rCtx.PubIDStr)
 			}
+			if glog.V(models.LogLevelDebug) {
+				bidRequest, _ := json.Marshal(payload.BidRequest)
+				glog.Infof("[bad_request] pubid:[%d] profid:[%d] endpoint:[%s] nbr:[%d] bidrequest:[%s]",
+					rCtx.PubID, rCtx.ProfileID, rCtx.Endpoint, result.NbrCode, string(bidRequest))
+			}
 		}
 	}()
 

diff --git a/modules/pubmatic/openwrap/entrypointhook.go b/modules/pubmatic/openwrap/entrypointhook.go
@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/buger/jsonparser"
+	"github.com/golang/glog"
 	"github.com/prebid/openrtb/v20/openrtb3"
 	"github.com/prebid/prebid-server/v2/config"
 	"github.com/prebid/prebid-server/v2/hooks/hookexecution"
@@ -48,10 +49,14 @@ func (m OpenWrap) handleEntrypointHook(
 	defer func() {
 		if result.Reject {
 			m.metricEngine.RecordBadRequests(endpoint, getPubmaticErrorCode(openrtb3.NoBidReason(result.NbrCode)))
-		} else {
-			result.ModuleContext = make(hookstage.ModuleContext)
-			result.ModuleContext["rctx"] = rCtx
+			if glog.V(models.LogLevelDebug) {
+				glog.Infof("[bad_request] pubid:[%d] profid:[%d] endpoint:[%s] nbr:[%d] query_params:[%s] body:[%s]",
+					rCtx.PubID, rCtx.ProfileID, rCtx.Endpoint, result.NbrCode, queryParams.Encode(), string(payload.Body))
+			}
+			return
 		}
+		result.ModuleContext = make(hookstage.ModuleContext)
+		result.ModuleContext["rctx"] = rCtx
 	}()
 
 	rCtx.Sshb = queryParams.Get("sshb")

diff --git a/modules/pubmatic/openwrap/matchedimpression.go b/modules/pubmatic/openwrap/matchedimpression.go
@@ -23,7 +23,7 @@ func getMatchedImpression(rctx models.RequestCtx) map[string]int {
 
 		syncer := syncerMap[syncerCode]
 		if syncer == nil {
-			glog.V(3).Infof("Invalid bidder code passed to ParseRequestCookies: %s ", partnerName)
+			glog.V(models.LogLevelDebug).Infof("Invalid bidder code passed to ParseRequestCookies: %s ", partnerName)
 		} else {
 			uid, _, _ := rctx.ParsedUidCookie.GetUID(syncer.Key())
 

diff --git a/modules/pubmatic/openwrap/metrics/stats/client.go b/modules/pubmatic/openwrap/metrics/stats/client.go
@@ -10,6 +10,7 @@ import (
 
 	"github.com/alitto/pond"
 	"github.com/golang/glog"
+	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models"
 )
 
 type HttpClient interface {
@@ -129,7 +130,7 @@ func (sc *Client) publishStatsToServer(statMap map[string]int) int {
 		return statusSetupFail
 	}
 
-	glog.V(3).Infof("[stats] nstats:[%d] data:[%s]", len(statMap), statJson)
+	glog.V(models.LogLevelDebug).Infof("[stats] nstats:[%d] data:[%s]", len(statMap), statJson)
 	req, err := http.NewRequest(http.MethodPost, sc.endpoint, bytes.NewBuffer(statJson))
 	if err != nil {
 		glog.Errorf("[stats_fail] Failed to form request to sent stats to server: %v", err)

diff --git a/modules/pubmatic/openwrap/models/constants.go b/modules/pubmatic/openwrap/models/constants.go
@@ -1,5 +1,7 @@
 package models
 
+import "github.com/golang/glog"
+
 const (
 	PARTNER_ID                  = "partnerId"
 	ADAPTER_ID                  = "adapterId"
@@ -604,3 +606,8 @@ const (
 	MissingSignal    = "missing"
 	InvalidSignal    = "invalid"
 )
+
+// constants for log level
+const (
+	LogLevelDebug glog.Level = 3
+)
diff --git a/modules/pubmatic/openwrap/unwrap/unwrap.go b/modules/pubmatic/openwrap/unwrap/unwrap.go
@@ -83,6 +83,6 @@ func (uw Unwrap) Unwrap(accountID, bidder string, bid *adapters.TypedBid, userAg
 		bid.Bid.AdM = string(respBody)
 	}
 
-	glog.V(3).Infof("[VAST_UNWRAPPER] pubid:[%v] bidder:[%v] impid:[%v] bidid:[%v] status_code:[%v] wrapper_cnt:[%v] httpRespCode= [%v] statsEnabled:[%v]",
+	glog.V(models.LogLevelDebug).Infof("[VAST_UNWRAPPER] pubid:[%v] bidder:[%v] impid:[%v] bidid:[%v] status_code:[%v] wrapper_cnt:[%v] httpRespCode= [%v] statsEnabled:[%v]",
 		accountID, bidder, bid.Bid.ImpID, bid.Bid.ID, respStatus, wrapperCnt, httpResp.Code, isStatsEnabled)
 }