UOE-11317: Log new NBR if response rejected by DSA (#950)

PubMatic-OpenWrap · Oct 24, 2024 · 287067f · 287067f
1 parent eb5ec27
commit 287067f
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/exchange/exchange.go b/exchange/exchange.go
@@ -14,6 +14,7 @@ import (
 	"strings"
 	"time"
 
+	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/models/nbr"
 	"github.com/prebid/prebid-server/v2/modules/pubmatic/openwrap/utils"
 	"github.com/prebid/prebid-server/v2/privacy"
 
@@ -1415,7 +1416,7 @@ func (e *exchange) makeBid(bids []*entities.PbsOrtbBid, auc *auction, returnCrea
 			}
 			bidResponseExt.Warnings[adapter] = append(bidResponseExt.Warnings[adapter], dsaMessage)
 			nonBidParams := entities.GetNonBidParamsFromPbsOrtbBid(bid, adapter.String())
-			nonBidParams.NonBidReason = int(ResponseRejectedGeneral)
+			nonBidParams.NonBidReason = int(nbr.ResponseRejectedDSA)
 			seatNonBids.AddBid(openrtb_ext.NewNonBid(nonBidParams), adapter.String())
 			continue // Don't add bid to result
 		}

diff --git a/exchange/exchange_test.go b/exchange/exchange_test.go
@@ -4972,7 +4972,7 @@ func TestMakeBidWithValidation(t *testing.T) {
 				seatNonBid := openrtb_ext.NonBidCollection{}
 				nonBid := openrtb_ext.NewNonBid(openrtb_ext.NonBidParams{
 					Bid:          &openrtb2.Bid{},
-					NonBidReason: 300,
+					NonBidReason: 620,
 					BidMeta: &openrtb_ext.ExtBidPrebidMeta{
 						AdapterCode: "pubmatic",
 					},

diff --git a/modules/pubmatic/openwrap/models/nbr/codes.go b/modules/pubmatic/openwrap/models/nbr/codes.go
@@ -33,4 +33,5 @@ const (
 	InvalidRedirectURL             openrtb3.NoBidReason = 617
 	InvalidResponseFormat          openrtb3.NoBidReason = 618
 	MissingOWRedirectURL           openrtb3.NoBidReason = 619
+	ResponseRejectedDSA            openrtb3.NoBidReason = 620 // Response Rejected - DSA
 )