Fixed test issues

modules/customIdSystem.js

@@ -5,8 +5,8 @@
  * @requires module:modules/userId
  */
 
-import * as utils from '../src/utils';
-import {submodule} from '../src/hook';
+import * as utils from '../src/utils.js';
+import {submodule} from '../src/hook.js';
 
 /** @type {Submodule} */
 export const customIdSubmodule = {

modules/pubmaticServerBidAdapter.js

@@ -1,8 +1,8 @@
-import * as utils from '../src/utils';
-import * as ajax from '../src/ajax';
-import {userSync} from '../src/userSync';
-import { config } from '../src/config';
-import { registerBidder } from '../src/adapters/bidderFactory';
+import * as utils from '../src/utils.js';
+import * as ajax from '../src/ajax.js';
+import {userSync} from '../src/userSync.js';
+import { config } from '../src/config.js';
+import { registerBidder } from '../src/adapters/bidderFactory.js';
 const constants = require('../src/constants.json');
 
 const BIDDER_CODE = 'pubmaticServer';

modules/widespaceBidAdapter.js

@@ -4,11 +4,14 @@ import {
   cookiesAreEnabled,
   hasLocalStorage,
   parseQueryStringParameters,
-  parseSizesInput
+  parseSizesInput,
+  setDataInLocalStorage,
+  setCookie,
+  getDataFromLocalStorage,
+  removeDataFromLocalStorage
 } from '../src/utils.js';
 import includes from 'core-js/library/fn/array/includes.js';
 import find from 'core-js/library/fn/array/find.js';
-import * as utils from '../src/utils.js';
 
 const BIDDER_CODE = 'widespace';
 const WS_ADAPTER_VERSION = '2.0.1';
@@ -178,12 +181,12 @@ export const spec = {
 function storeData(data, name, stringify = true) {
   const value = stringify ? JSON.stringify(data) : data;
   if (LOCAL_STORAGE_AVAILABLE) {
-    utils.setDataInLocalStorage(name, value);
+    setDataInLocalStorage(name, value);
     return true;
   } else if (COOKIE_ENABLED) {
     const theDate = new Date();
     const expDate = new Date(theDate.setMonth(theDate.getMonth() + 12)).toGMTString();
-    utils.setCookie(name, value, expDate);
+    setCookie(name, value, expDate);
     return true;
   }
 }
@@ -193,9 +196,9 @@ function getData(name, remove = true) {
   if (LOCAL_STORAGE_AVAILABLE) {
     Object.keys(localStorage).filter((key) => {
       if (key.indexOf(name) > -1) {
-        data.push(utils.getDataFromLocalStorage(key));
+        data.push(getDataFromLocalStorage(key));
         if (remove) {
-          utils.removeDataFromLocalStorage(key);
+          removeDataFromLocalStorage(key);
         }
       }
     });
@@ -207,7 +210,7 @@ function getData(name, remove = true) {
       if (value[0].indexOf(name) > -1) {
         data.push(value[1]);
         if (remove) {
-          utils.setCookie(value[0], '', 'Thu, 01 Jan 1970 00:00:01 GMT');
+          setCookie(value[0], '', 'Thu, 01 Jan 1970 00:00:01 GMT');
         }
       }
     });

test/spec/modules/pubmaticBidAdapter_spec.js

@@ -2327,113 +2327,113 @@ describe('PubMatic adapter', function () {
     });
   });
 
-    it('Request params deals check', function () {
-      let multipleBidRequests = [
+  it('Request params deals check', function () {
+    let multipleBidRequests = [
+      {
+        bidder: 'pubmatic',
+        params: {
+          publisherId: '301',
+          adSlot: '/15671365/DMDemo@300x250:0',
+          kadfloor: '1.2',
+          pmzoneid: 'aabc, ddef',
+          kadpageurl: 'www.publisher.com',
+          yob: '1986',
+          gender: 'M',
+          lat: '12.3',
+          lon: '23.7',
+          wiid: '1234567890',
+          profId: '100',
+          verId: '200',
+          currency: 'AUD',
+          deals: ['deal-id-1', 'deal-id-2', 'dea'] // "dea" will not be passed as more than 3 characters needed
+        },
+        placementCode: '/19968336/header-bid-tag-1',
+        sizes: [[300, 250], [300, 600]],
+        bidId: '23acc48ad47af5',
+        requestId: '0fb4905b-9456-4152-86be-c6f6d259ba99',
+        bidderRequestId: '1c56ad30b9b8ca8',
+        transactionId: '92489f71-1bf2-49a0-adf9-000cea934729'
+      },
+      {
+        bidder: 'pubmatic',
+        params: {
+          publisherId: '301',
+          adSlot: '/15671365/DMDemo@300x250:0',
+          kadfloor: '1.2',
+          pmzoneid: 'aabc, ddef',
+          kadpageurl: 'www.publisher.com',
+          yob: '1986',
+          gender: 'M',
+          lat: '12.3',
+          lon: '23.7',
+          wiid: '1234567890',
+          profId: '100',
+          verId: '200',
+          currency: 'GBP',
+          deals: ['deal-id-100', 'deal-id-200']
+        },
+        placementCode: '/19968336/header-bid-tag-1',
+        sizes: [[300, 250], [300, 600]],
+        bidId: '23acc48ad47af5',
+        requestId: '0fb4905b-9456-4152-86be-c6f6d259ba99',
+        bidderRequestId: '1c56ad30b9b8ca8',
+        transactionId: '92489f71-1bf2-49a0-adf9-000cea934729'
+      }
+    ];
+
+    let request = spec.buildRequests(multipleBidRequests);
+    let data = JSON.parse(request.data);
+    // case 1 - deals are passed as expected, ['', ''] , in both adUnits
+    expect(data.imp[0].pmp).to.deep.equal({
+      'private_auction': 0,
+      'deals': [
         {
-          bidder: 'pubmatic',
-          params: {
-            publisherId: '301',
-            adSlot: '/15671365/DMDemo@300x250:0',
-            kadfloor: '1.2',
-            pmzoneid: 'aabc, ddef',
-            kadpageurl: 'www.publisher.com',
-            yob: '1986',
-            gender: 'M',
-            lat: '12.3',
-            lon: '23.7',
-            wiid: '1234567890',
-            profId: '100',
-            verId: '200',
-            currency: 'AUD',
-            deals: ['deal-id-1', 'deal-id-2', 'dea'] // "dea" will not be passed as more than 3 characters needed
-          },
-          placementCode: '/19968336/header-bid-tag-1',
-          sizes: [[300, 250], [300, 600]],
-          bidId: '23acc48ad47af5',
-          requestId: '0fb4905b-9456-4152-86be-c6f6d259ba99',
-          bidderRequestId: '1c56ad30b9b8ca8',
-          transactionId: '92489f71-1bf2-49a0-adf9-000cea934729'
+          'id': 'deal-id-1'
         },
         {
-          bidder: 'pubmatic',
-          params: {
-            publisherId: '301',
-            adSlot: '/15671365/DMDemo@300x250:0',
-            kadfloor: '1.2',
-            pmzoneid: 'aabc, ddef',
-            kadpageurl: 'www.publisher.com',
-            yob: '1986',
-            gender: 'M',
-            lat: '12.3',
-            lon: '23.7',
-            wiid: '1234567890',
-            profId: '100',
-            verId: '200',
-            currency: 'GBP',
-            deals: ['deal-id-100', 'deal-id-200']
-          },
-          placementCode: '/19968336/header-bid-tag-1',
-          sizes: [[300, 250], [300, 600]],
-          bidId: '23acc48ad47af5',
-          requestId: '0fb4905b-9456-4152-86be-c6f6d259ba99',
-          bidderRequestId: '1c56ad30b9b8ca8',
-          transactionId: '92489f71-1bf2-49a0-adf9-000cea934729'
+          'id': 'deal-id-2'
         }
-      ];
-
-      let request = spec.buildRequests(multipleBidRequests);
-      let data = JSON.parse(request.data);
-      // case 1 - deals are passed as expected, ['', ''] , in both adUnits
-      expect(data.imp[0].pmp).to.deep.equal({
-        'private_auction': 0,
-        'deals': [
-          {
-            'id': 'deal-id-1'
-          },
-          {
-            'id': 'deal-id-2'
-          }
-        ]
-      });
-      expect(data.imp[1].pmp).to.deep.equal({
-        'private_auction': 0,
-        'deals': [
-          {
-            'id': 'deal-id-100'
-          },
-          {
-            'id': 'deal-id-200'
-          }
-        ]
-      });
-
-      // case 2 - deals not present in adunit[0]
-      delete multipleBidRequests[0].params.deals;
-      request = spec.buildRequests(multipleBidRequests);
-      data = JSON.parse(request.data);
-      expect(data.imp[0].pmp).to.not.exist;
-
-      // case 3 - deals is present in adunit[0], but is not an array
-      multipleBidRequests[0].params.deals = 123;
-      request = spec.buildRequests(multipleBidRequests);
-      data = JSON.parse(request.data);
-      expect(data.imp[0].pmp).to.not.exist;
+      ]
+    });
+    expect(data.imp[1].pmp).to.deep.equal({
+      'private_auction': 0,
+      'deals': [
+        {
+          'id': 'deal-id-100'
+        },
+        {
+          'id': 'deal-id-200'
+        }
+      ]
+    });
 
-      // case 4 - deals is present in adunit[0] as an array but one of the value is not a string
-      multipleBidRequests[0].params.deals = [123, 'deal-id-1'];
-      request = spec.buildRequests(multipleBidRequests);
-      data = JSON.parse(request.data);
-      expect(data.imp[0].pmp).to.deep.equal({
-        'private_auction': 0,
-        'deals': [
-          {
-            'id': 'deal-id-1'
-          }
-        ]
-      });
+    // case 2 - deals not present in adunit[0]
+    delete multipleBidRequests[0].params.deals;
+    request = spec.buildRequests(multipleBidRequests);
+    data = JSON.parse(request.data);
+    expect(data.imp[0].pmp).to.not.exist;
+
+    // case 3 - deals is present in adunit[0], but is not an array
+    multipleBidRequests[0].params.deals = 123;
+    request = spec.buildRequests(multipleBidRequests);
+    data = JSON.parse(request.data);
+    expect(data.imp[0].pmp).to.not.exist;
+
+    // case 4 - deals is present in adunit[0] as an array but one of the value is not a string
+    multipleBidRequests[0].params.deals = [123, 'deal-id-1'];
+    request = spec.buildRequests(multipleBidRequests);
+    data = JSON.parse(request.data);
+    expect(data.imp[0].pmp).to.deep.equal({
+      'private_auction': 0,
+      'deals': [
+        {
+          'id': 'deal-id-1'
+        }
+      ]
     });
+  });
 
-    describe('Request param bcat checking', function() {
+  describe('Request param bcat checking', function() {
     let multipleBidRequests = [
       {
         bidder: 'pubmatic',
@@ -2452,7 +2452,7 @@ describe('PubMatic adapter', function () {
           verId: '200',
           currency: 'AUD',
           dctr: 'key1=val1|key2=val2,!val3'
-          },
+        },
         placementCode: '/19968336/header-bid-tag-1',
         sizes: [[300, 250], [300, 600]],
         bidId: '23acc48ad47af5',