Skip to content

Commit

Permalink
Modbus: fix log output no longer displayed (evcc-io#15276)
Browse files Browse the repository at this point in the history
  • Loading branch information
andig authored Aug 7, 2024
1 parent e779bb8 commit 7f86118
Showing 1 changed file with 18 additions and 7 deletions.
25 changes: 18 additions & 7 deletions util/modbus/modbus.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,22 +61,33 @@ func (s *Settings) String() string {
return s.Device
}

type meterConnection struct {
meters.Connection
*logger
}

var (
connections = make(map[string]meters.Connection)
connections = make(map[string]*meterConnection)
mu sync.Mutex
)

func registeredConnection(key string, newConn meters.Connection) meters.Connection {
func registeredConnection(key string, newConn meters.Connection) *meterConnection {
mu.Lock()
defer mu.Unlock()

if conn, ok := connections[key]; ok {
return conn
}

connections[key] = newConn
connection := &meterConnection{
Connection: newConn,
logger: new(logger),
}

newConn.Logger(connection.logger)
connections[key] = connection

return newConn
return connection
}

// NewConnection creates physical modbus device from config
Expand All @@ -93,14 +104,14 @@ func NewConnection(uri, device, comset string, baudrate int, proto Protocol, sla

res := &Connection{
Connection: conn.Clone(slaveID),
logger: new(logger),
logger: conn.logger,
}

return res, nil
}

func physicalConnection(proto Protocol, cfg Settings) (meters.Connection, error) {
var conn meters.Connection
func physicalConnection(proto Protocol, cfg Settings) (*meterConnection, error) {
var conn *meterConnection

if (cfg.Device != "") == (cfg.URI != "") {
return nil, errors.New("invalid modbus configuration: must have either uri or device")
Expand Down

0 comments on commit 7f86118

Please sign in to comment.