exposure: full-picture: fix deformed thumbnails for videos #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
videos full-picture class used to fit the whole screen which is fine for photos since they're cropped. However when a video is to be put in full-picture class, its width is limited to the one of the display though its thumbnail still has its width and height set to 100%. This makes the thumbnail not respect its original ratio and results in in the video being surrounded by deformed parts of the thumbnail (the thumbnail taking 100% of the display height while the video only takes whatever is needed to respect the ratio with the width being 100% of the display's). Fixes Psycojoker#138. Signed-off-by: Quentin Schulz <foss@0leil.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full-picture class used to fit the whole screen which is fine for photos
since they're cropped.
However when a video is to be put in full-picture class, its width is
limited to the one of the display though its thumbnail still has its
width and height set to 100%.
This makes the thumbnail not respect its original ratio and results in
in the video being surrounded by deformed parts of the thumbnail (the
thumbnail taking 100% of the display height while the video only takes
whatever is needed to respect the ratio with the width being 100% of
the display's).
Fixes #138.
Note: this branch conflicts with #137 though the conflict should be easy to resolve. I can rebase this branch or the other once one is merged if it makes it easier for maintainers to merge everything.