-
Notifications
You must be signed in to change notification settings - Fork 12
Open
Labels
Milestone
Description
Description
I've noticed more Crash exceptions from Sentry regarding the Out of Memory. We should investigate it
✅ Please read some blogs to understand how to do the Memory Profile in the ElectronJS app.
Acceptance Criteria
Verify the following scenario
- Open the Activity monitor to check the Memory Usage at the launch time (No Request in the main table)
- Add a * wildcard to the SSL Proxying List
- Make a bunch of requests to capture all HTTPS traffic
- -> Verify the Memory Usage is increased
- Clear Session
- Confirm the memory usage is back to normal ✅
- If the Memory Usage is back to normal level after clearing the Session -> It indicates that there is no leak -> All captured HTTP/HTTPS flows are clean.
- Otherwise -> It means these capture flows doesn't release properly -> Bug ❌
Verify the IPC listener are removed if the component is unmounted.
- It's a common mistake that we didn't remove the Listener when the component is unmounted.
Ref: https://stackoverflow.com/a/76233938/3127477 - Review all listeners in the both main / renderer processes -> Verify we don't have these mistakes -> If it's -> Fix it ✅
How to review
- Book a Video Call with me, and explain your process -> How you tackle the problem -> After & Before result -> Screenshot/video in the PR and live demo ✅