Get pending job list from the session during authentication #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result is that should_run? will only be called once per job. Previously the auth method reconstructed the pending jobs list from scratch immediately after it was built and stored in the session, making it possible for conditionally run jobs to produce a different result, a situation which QBWC is not equipped to handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result is that should_run? will only be called once per job.
Previously the auth method reconstructed the pending jobs list
from scratch immediately after it was built and stored in the session,
making it possible for conditionally run jobs to produce a different
result, a situation which QBWC is not equipped to handle