Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.8.11] - 2025-06-12

### Fixed

- The Pod Disruption Template used `app` as the matchLabels selector, but the selector used by Deployments and all the various resources is `selector`. This aligns PDBs with the rest of the resources.

## [1.8.10] - 2025-04-28

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion charts/common/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v2
description: Common service chart
name: common
type: library
version: 1.8.10
version: 1.8.11
maintainers:
- name: DevOps
2 changes: 1 addition & 1 deletion charts/common/templates/_pod_disruption_budget.yaml.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ spec:
{{- end }}
selector:
matchLabels:
app: {{ .selector }}
selector: {{ .selector }}
{{- end }}
6 changes: 3 additions & 3 deletions test/fixtures/Chart.lock
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
dependencies:
- name: common
repository: file://../../../charts/common
version: 1.8.10
digest: sha256:5c2b200bbb4249e60460b9819c53a2b0aed75121efd63230d6c30072c5287690
generated: "2025-04-28T10:35:06.013118-05:00"
version: 1.8.11
digest: sha256:4fe74fe2679fb4f0f3bd4220c47ac915af93407948724f4c5c4d94302955efeb
generated: "2025-06-12T10:41:21.573804-05:00"
2 changes: 1 addition & 1 deletion test/fixtures/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ version: 1.0.0
dependencies:
- name: common
repository: file://../../../charts/common
version: "1.8.10"
version: "1.8.11"
2 changes: 1 addition & 1 deletion test/test_deployments.bats
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ teardown() {
run helm template -f test/fixtures/deployments/values-pdb-minAvailable.yaml test/fixtures/deployments/
assert_output --partial 'kind: PodDisruptionBudget'
assert_output --partial 'name: my-cool-app-web-pdb'
assert_output --partial 'app: my-cool-app-deployment-web'
assert_output --partial 'selector: my-cool-app-deployment-web'
assert_output --partial 'minAvailable: 1'
}

Expand Down