Add option for services to redirect a base domain to www. for ALB#16
Merged
Add option for services to redirect a base domain to www. for ALB#16
Conversation
Adds a redirectHostToWWW option which takes the base domain to apply a www redirect to and creates the relevant ALB annotations. This option seems a little overly specific and like it could be a map allowing arbitrary redirects to any of a service's hostnames, but went with this since our only existing use case is for redirecting sevenfifty.com domains to www and to avoid adding a lot of extra go template code that might not be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a redirectHostToWWW option which takes the base domain to apply a www redirect to and creates the relevant ALB annotations.
This option seems a little overly specific and like it could be a map allowing arbitrary redirects to any of a service's hostnames, but went with this since our only existing use case is for redirecting sevenfifty.com domains to www and to avoid adding a lot of extra go template code that might not be used.