Skip to content

Comments

Add ingress list for hostname aliases#14

Merged
mwojo merged 1 commit intomainfrom
add-hostname-aliases
Jan 2, 2025
Merged

Add ingress list for hostname aliases#14
mwojo merged 1 commit intomainfrom
add-hostname-aliases

Conversation

@mwojo
Copy link
Contributor

@mwojo mwojo commented Dec 23, 2024

Allows specifying a list of aliases like

    hostnames:
      - d2.easteighth.com
    hostnameAliases:
      - distiller.easteighth.com
      - qb.easteighth.com

And adds these to the necessary host-header config in ALB.

This is needed for alternate host headers to work together with the imperva option in our charts which also sets/overrides this annotation.

Allows specifying a list of aliases like

```yaml
    hostnames:
      - d2.easteighth.com
    hostnameAliases:
      - distiller.easteighth.com
      - qb.easteighth.com
```

And adds these to the necessary host-header config in ALB.

This is needed for alternate host headers to work together with the
imperva option in our charts which also sets/overrides this annotation.
@mwojo
Copy link
Contributor Author

mwojo commented Dec 23, 2024

For supporting distiller's aliases and storefronts in the SF EKS migration https://teamprovi.slack.com/archives/C067H31SX8B/p1734650713946479

Copy link
Contributor

@creisor creisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@mwojo mwojo merged commit 2a160b3 into main Jan 2, 2025
@mwojo mwojo deleted the add-hostname-aliases branch January 2, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants